Merge pull request #208 from henninghall/scrolls-beyond-not-always-trigger-onchange

bugfix: scrolls beyond min/max date not always triggering onChange

android/src/main/java/com/henninghall/date_picker/State.java

@@ -97,9 +97,12 @@ public class State {
         return utc ? TimeZone.getTimeZone("UTC") : TimeZone.getDefault();
     }
 
+    public String getDateString() {
+        return (String) dateProp.getValue();
+    }
+
     public Calendar getDate() {
-        String date = (String) dateProp.getValue();
-        return Utils.isoToCalendar(date, getTimeZone());
+        return Utils.isoToCalendar(getDateString(), getTimeZone());
     }
 
     public Integer getHeight() {

android/src/main/java/com/henninghall/date_picker/ui/UIManager.java

@@ -67,11 +67,12 @@ public class UIManager {
         return new SimpleDateFormat(wheels.getFormatPattern(), state.getLocale());
     }
 
-    String getDateString() {
+    String getDisplayValueString() {
         return wheels.getDisplayValue();
     }
 
     void animateToDate(Calendar date) {
+        wheels.applyOnInVisible(new SetDate(date));
         wheels.applyOnVisible(new AnimateToDate(date));
     }
 

android/src/main/java/com/henninghall/date_picker/ui/WheelChangeListenerImpl.java

@@ -6,7 +6,6 @@ import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.WritableMap;
 import com.facebook.react.uimanager.events.RCTEventEmitter;
 import com.henninghall.date_picker.DatePickerManager;
-import com.henninghall.date_picker.PickerView;
 import com.henninghall.date_picker.State;
 import com.henninghall.date_picker.Utils;
 import com.henninghall.date_picker.wheels.Wheel;
@@ -44,12 +43,12 @@ public class WheelChangeListenerImpl implements WheelChangeListener {
             String toParse = wheels.getDateString();
             Date newDate = dateFormat.parse(toParse);
             date.setTime(newDate);
-
+            String dateString = Utils.dateToIso(date);
             if (minDate != null && date.before(minDate)) uiManager.animateToDate(minDate);
             else if (maxDate != null && date.after(maxDate)) uiManager.animateToDate(maxDate);
             else {
-                event.putString("date", Utils.dateToIso(date));
-                event.putString("dateString", uiManager.getDateString());
+                event.putString("date", dateString);
+                event.putString("dateString", uiManager.getDisplayValueString());
                 DatePickerManager.context.getJSModule(RCTEventEmitter.class)
                         .receiveEvent(rootView.getId(), "dateChange", event);
             }

android/src/main/java/com/henninghall/date_picker/ui/Wheels.java

@@ -63,21 +63,20 @@ public class Wheels {
         return (Picker) rootView.findViewById(id);
     }
 
-    private Collection<Wheel> getVisible() {
-        ArrayList<WheelType> wheelTypes = state.derived.getVisibleWheels();
-        Collection<Wheel> wheels = new ArrayList<>();
-        for (WheelType type: wheelTypes){
-            wheels.add(getWheel(type));
-        }
-        return wheels;
-    }
-
     void applyOnAll(WheelFunction function) {
         for (Wheel wheel: getAll()) function.apply(wheel);
     }
 
     void applyOnVisible(WheelFunction function) {
-        for (Wheel wheel: getVisible()) function.apply(wheel);
+        for(Wheel wheel: getAll()) {
+            if(wheel.visible()) function.apply(wheel);
+        }
+    }
+
+    void applyOnInVisible(WheelFunction function) {
+        for(Wheel wheel: getAll()) {
+            if(!wheel.visible()) function.apply(wheel);
+        }
     }
 
     void updateHeight() {